Skip to content

Multi platform Docker images #83

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
ismailkarsli wants to merge 15 commits into from
Closed

Multi platform Docker images #83

ismailkarsli wants to merge 15 commits into from

Conversation

@ismailkarsli
Copy link

@ismailkarsli ismailkarsli commented Aug 27, 2023 •
edited
Loading

I didn't delete the compose files because I wasn't sure of their necessity. I got the following output on ARM. I'm assuming it's working. Also its working as you wanted, running only when a release created.

reiverr    | 
reiverr    | > [email protected] dev
reiverr    | > vite dev --host
reiverr    | 
reiverr    | 
reiverr    |   VITE v4.3.9  ready in 260 ms
reiverr    | 
reiverr    |   ➜  Local:   http://localhost:5173/
reiverr    |   ➜  Network: http://172.22.0.2:5173/
reiverr    | (!) Could not auto-determine entry point from rollupOptions or html files and there are no explicit optimizeDeps.include patterns. Skipping dependency pre-bundling.

@ismailkarsli
Copy link
Author

ismailkarsli commented Aug 27, 2023 •
edited
Loading

Here's the;
Releases https://github.com/ismailkarsli/reiverr/releases
Final build https://github.com/ismailkarsli/reiverr/pkgs/container/reiverr/122374302?tag=latest

@ismailkarsli ismailkarsli marked this pull request as draft August 27, 2023 16:18
@ismailkarsli
Copy link
Author

ismailkarsli commented Aug 27, 2023 •
edited
Loading

It was running dev mode with the Dockerfile, I changed so many things to run it on prod and its not working now :D

@aleksilassila
Copy link
Owner

aleksilassila commented Aug 29, 2023

Hey, let me know when this is ready to be reviewed

@ismailkarsli
Copy link
Author

ismailkarsli commented Aug 30, 2023

Hey, let me know when this is ready to be reviewed

Can I make major changes? For example removing compose files, changes in package-json, Dockerfile etc. I don't want it to go to waste.

@ismailkarsli ismailkarsli marked this pull request as ready for review August 30, 2023 09:22
İsmail Karslı added 2 commits August 30, 2023 12:26
ci: docker multi platform build take 1
4b92c29 
ci: trigger ci

ci: gh workflow build with cache

build: removed dev from Dockerfile
build: removed compose files and changed docker port settings

move production env to bottom

move port to the bottom

fix: Dockerfile command changed to node

ci: do not re-download packages
Merge branch 'master' of github.com:ismailkarsli/reiverr
e1945b5
@ismailkarsli
Copy link
Author

ismailkarsli commented Aug 30, 2023

Alright done. It working as expected on ARM now. Also you can specify port with PORT env now. For example;
docker run --port 8080:8080 --env PORT=8080 reiverr
or with default
docker run --port 9494:9494 reiverr

@bjornlll
Copy link

bjornlll commented Jul 30, 2024

When are we merging this?

@ismailkarsli
Copy link
Author

ismailkarsli commented Jul 31, 2024

I added the latest changes.

@aleksilassila
Copy link
Owner

aleksilassila commented Jul 31, 2024

Is this ready? I could try getting this reviewed and merged

@ismailkarsli
Copy link
Author

ismailkarsli commented Jul 31, 2024

Yes, it is ready.

@EsdrubalMagano
Copy link

EsdrubalMagano commented Mar 21, 2025

When is it merging?

@ismailkarsli ismailkarsli closed this by deleting the head repository Aug 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

Reiverr 1.0 Taskboard
Status: Todo

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@ismailkarsli @aleksilassila @bjornlll @EsdrubalMagano